Lee-W commented on code in PR #36445:
URL: https://github.com/apache/airflow/pull/36445#discussion_r1437975093
##########
tests/always/test_providers_manager.py:
##########
@@ -384,6 +384,11 @@ def test_notification(self):
notification_class_names = list(provider_manager.notification)
assert len(notification_class_names) > 5
+ def test_auth_managers(self):
+ provider_manager = ProvidersManager()
+ notification_class_names = list(provider_manager.auth_managers)
+ assert len(notification_class_names) > 0
Review Comment:
Should we check the names contain the expected content?
##########
airflow/cli/commands/provider_command.py:
##########
@@ -189,7 +189,20 @@ def auth_backend_list(args):
data=list(ProvidersManager().auth_backend_module_names),
output=args.output,
mapper=lambda x: {
- "api_auth_backand_module": x,
+ "api_auth_backend_module": x,
+ },
+ )
+
+
+@suppress_logs_and_warning
+@providers_configuration_loaded
+def auth_managers_list(args):
+ """List all auth managers at the command line."""
+ AirflowConsole().print_as(
+ data=list(ProvidersManager().auth_managers),
Review Comment:
looks like `auth_managers` property return `list[str]`. Do we still need the
`list` wrap here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
