potiuk commented on PR #35868: URL: https://github.com/apache/airflow/pull/35868#issuecomment-1872248350
> @potiuk Yes, before re-basing another 10 times, I'd like to get this off the plate and merged. So your advise and prep help might help: > > * I assume all feedback consistently points that the migration tool shall not be in the Airflow mono repo. If there would be any kind of other GIT repo that you can create or point to to bring [Add a migration script tooling support to migrate off mssql #35861](https://github.com/apache/airflow/pull/35861) to then this would be a good pre-requisite. This PR needs to point to migration tool in docs. I do not have a strong opinion where to store the migration tool but woul dbe better also not pointing to my personal account. I created https://github.com/apache/airflow-mssql-migration . In about 5 minutes permissions should be set there and you should be able to initiate it an push the migration tooling there (even directly without PR/Approval). We can setup branch protection later when it settles down, for now it's ok to **just** push the changes there (but if you prefer to open PRs it's also fine - happy to review them). > * This PR is quite large, the debate around migration script clean is not settled. I would be OK to revert. Maybe separating into at least two PRs might make discussion easier. (PR1: Removal of support form core + breeze / PR2: Clean up of leftovers in migration tooling) Yeah. I would rather do it in reverse: - Create migration tooling outside (it does not have to be final version - just enough to be "working" - we can iterate and improve it later - Add link to it for people who want to migrate in PR 1 (we will keep updating it when we know exactly which version we should migrate to and maybe get some clarification about migration process - Only after we have this set up as base, we should have PR 2 with removing the support. There is a bit of problem potentially for cherry-picking, but I think the probability of difficult change that we would like to cherry-pick that will break MSSQL is very low and we will still have mssql tests running in v2-8-test so as long as @ephraimbuddy is ok with it and we commit to quickly fixing those kind of issues (or not-cherry-picking them in the first place) we can merge it even now. > * Development advise in regards: Would it be OK to merge this to main "soon" or for better patch maintenance of 2.8-line do we need to keep this removal as a PR open for longer? Otherwise nobody really made a review, and I don't want all the efforts being dropped/wasted as actually I had positive intention as a follow-up of the vote to clean-up MSSQL but missing support for review here. Yeah. See above, I think with just dropping MSSQL the chance of breaking cherry-picking is rather low (and in that case we would likely not cherry-pick it anyway - as I see it only happening for new features). But I'd love to hear what others say as well (especially @ephraimbuddy ). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
