potiuk commented on PR #36504: URL: https://github.com/apache/airflow/pull/36504#issuecomment-1872896761
Also - I tihnk there is a completely separate question on what we do with "secrets" . I guess this sync/async configuration should also apply to secrets and we should extend our SecretsManager API to cover those cases as well: a) have a way to inform if sync/async is supported b) support it :) We should also likely have some kind of consistency check - i.e. if Airlfow uses a secrets manager, "async" cannot be enabled unless both driver and secrets manager used suppport async - and in this case Trigger should only work "asynchronously" in case the whole "airflow" installation (DB + Secrets Manager) is async capable, otherwise it should fall-back to sync (i.e. if they need Connections/Variables during event loop handling, they should be passed via - possibly encrypted - serialized data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
