pankajastro commented on code in PR #36630:
URL: https://github.com/apache/airflow/pull/36630#discussion_r1443739164
##########
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##########
@@ -319,11 +320,38 @@ def post_dag_run(*, dag_id: str, session: Session =
NEW_SESSION) -> APIResponse:
if not dagrun_instance:
try:
dag = get_airflow_app().dag_bag.get_dag(dag_id)
+
+ data_interval_start_exists = (
+ "data_interval_start" in post_body and
post_body["data_interval_start"] is not None
+ )
+ data_interval_end_exists = (
+ "data_interval_end" in post_body and
post_body["data_interval_end"] is not None
+ )
Review Comment:
```suggestion
data_interval_start_exists =
post_body.get("data_interval_start") is not None
data_interval_end_exists = post_body.get("data_interval_end") is
not None
```
wdyt about using get here
##########
tests/api_connexion/endpoints/test_dag_run_endpoint.py:
##########
@@ -1076,32 +1076,62 @@ def test_end_date_gte_lte(self, payload,
expected_dag_run_ids):
class TestPostDagRun(TestDagRunEndpoint):
@pytest.mark.parametrize("logical_date_field_name", ["execution_date",
"logical_date"])
@pytest.mark.parametrize(
- "dag_run_id, logical_date, note",
+ "dag_run_id, logical_date, note, data_interval_start,
data_interval_end",
[
- pytest.param("TEST_DAG_RUN", "2020-06-11T18:00:00+00:00",
"test-note", id="all-present"),
- pytest.param(None, "2020-06-11T18:00:00+00:00", None,
id="only-date"),
- pytest.param(None, None, None, id="all-missing"),
+ pytest.param(
+ "TEST_DAG_RUN", "2020-06-11T18:00:00+00:00", "test-note",
None, None, id="all-present"
+ ),
+ pytest.param(
+ "TEST_DAG_RUN",
+ "2024-06-11T18:00:00+00:00",
+ "test-note",
+ "2024-01-03T00:00:00+00:00",
+ "2024-01-04T05:00:00+00:00",
+ id="all-present-with-dates",
+ ),
+ pytest.param(None, "2020-06-11T18:00:00+00:00", None, None, None,
id="only-date"),
+ pytest.param(None, None, None, None, None, id="all-missing"),
],
)
- def test_should_respond_200(self, session, logical_date_field_name,
dag_run_id, logical_date, note):
+ def test_should_respond_200(
+ self,
+ session,
+ logical_date_field_name,
+ dag_run_id,
+ logical_date,
+ note,
+ data_interval_start,
+ data_interval_end,
+ ):
self._create_dag("TEST_DAG_ID")
# We'll patch airflow.utils.timezone.utcnow to always return this so we
# can check the returned dates.
fixed_now = timezone.utcnow()
+ # raise NotImplementedError("TODO: Add tests for data_interval_start
and data_interval_end")
+
request_json = {}
if logical_date is not None:
request_json[logical_date_field_name] = logical_date
if dag_run_id is not None:
request_json["dag_run_id"] = dag_run_id
+ if data_interval_start is not None:
+ request_json["data_interval_start"] = data_interval_start
+ if data_interval_end is not None:
+ request_json["data_interval_end"] = data_interval_end
+
request_json["note"] = note
with mock.patch("airflow.utils.timezone.utcnow", lambda: fixed_now):
response = self.client.post(
"api/v1/dags/TEST_DAG_ID/dagRuns",
json=request_json,
environ_overrides={"REMOTE_USER": "test"},
)
+
+ if response.status_code == 400:
+ print(response.json)
Review Comment:
we should use assert here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
