potiuk commented on code in PR #36638:
URL: https://github.com/apache/airflow/pull/36638#discussion_r1443988533
##########
scripts/ci/pre_commit/pre_commit_mypy.py:
##########
@@ -51,19 +55,26 @@
"MOUNT_SOURCES": "selected",
},
)
+ci_environment = os.environ.get("CI")
if res.returncode != 0:
+ if mypy_packages and ci_environment:
+ console.print(
+ "[yellow]You are running mypy with the packages selected. If you
want to"
+ "reproduce it locally, you need to run the following command:\n"
+ )
+ console.print(
+ f'MYPY_PACKAGES="{mypy_packages}" pre-commit run --hook-stage
manual mypy --all-files\n'
Review Comment:
I think one check with variable (especially that usually it will be run only
when CI fails and you will get clear instructions) is probably better UX
experience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
