potiuk commented on PR #36641: URL: https://github.com/apache/airflow/pull/36641#issuecomment-1880078290
> > Very nice! Indeed that nicely solves the most pressing need of partial retrieval of the DAG / DAGRun. > > Can you please add some tests covering this ? > > @potiuk Hi! Since I am new to airflow, could you please tell me in a nutshell how the test code works? Does my PR just need to add tests code in `tests/api_connexion/endpoints/test_dag_endpoint.py#TestGetDag`, `TestGetDagDetails` etc ? > > Do I need to test anything specifically? such as each field be returned correctly? Yes. You should add code there just a few examples testing what happens when you run API call with and without field specieifcation - ideally look at other test cases and write similar tests, this is the easiest way to get started with your tests. Generally the tests will be executed automatically in CI and all the tests of ours are easily runnable locally. We have various kinds of tests, but the API tests are just standard unit tests and you have all the docs about running tests - both in local venv, IDE and also in `breeze` (which is 1-1 replica of what happens in CI using docker compose) in https://github.com/apache/airflow/blob/main/TESTING.rst#running-unit-tests - it contains screenshots of how to configure your IDEs etc. We have also a more generic CONTRIBUTING information https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst how to setup your environment and you will even find QUICK_START quides there specific for popular IDES. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
