dirrao commented on code in PR #36705: URL: https://github.com/apache/airflow/pull/36705#discussion_r1447022943
########## airflow/cli/commands/variable_command.py: ########## @@ -61,8 +61,25 @@ def variables_get(args): @providers_configuration_loaded def variables_set(args): """Create new variable with a given name, value and description.""" - Variable.set(args.key, args.value, args.description, serialize_json=args.json) - print(f"Variable {args.key} created") + if args.json_file: Review Comment: This functionality already exists. Check the CLI command as follows. I don't think this is needed. ``` usage: airflow variables import [-h] file Import variables positional arguments: file Import variables from JSON file optional arguments: -h, --help show this help message and exit ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org