vincbeck commented on code in PR #36537:
URL: https://github.com/apache/airflow/pull/36537#discussion_r1447742983


##########
airflow/providers/fab/provider.yaml:
##########
@@ -36,6 +36,11 @@ versions:
 dependencies:
   - apache-airflow>=2.9.0
   - flask>=2.2,<2.3
+  # We are tightly coupled with FAB version as we vendored-in part of FAB code 
related to security manager
+  # This is done as part of preparation to removing FAB as dependency, but we 
are not ready for it yet
+  # Every time we update FAB version here, please make sure that you review 
the classes and models in
+  # `airflow/providers/fan/auth_manager/security_manager/override.py` with 
their upstream counterparts.

Review Comment:
   Typo is still there :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to