hussein-awala commented on code in PR #36714:
URL: https://github.com/apache/airflow/pull/36714#discussion_r1447837028
##########
docs/apache-airflow/howto/docker-compose/index.rst:
##########
@@ -319,14 +319,14 @@ you should do those steps:
.. code-block:: docker
- #image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:2.6.1}
+ #image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:2.8.0}
build: .
2) Create ``Dockerfile`` in the same folder your ``docker-compose.yaml`` file
is with content similar to:
.. code-block:: docker
- FROM apache/airflow:2.6.1
+ FROM apache/airflow:2.8.0
Review Comment:
to avoid updating it after each release, maybe we can use:
```suggestion
FROM apache/airflow:${AIRFLOW_VERSION}
```
as we do after two lines.
##########
docs/apache-airflow/howto/docker-compose/index.rst:
##########
@@ -319,14 +319,14 @@ you should do those steps:
.. code-block:: docker
- #image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:2.6.1}
+ #image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:2.8.0}
Review Comment:
And here we can use:
```suggestion
#image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:<airflow version>}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
