nathadfield commented on PR #34715:
URL: https://github.com/apache/airflow/pull/34715#issuecomment-1886952539

   This might be slightly off topic for this PR but, when talking about the 
behaviour of sensors in general, I feel like there's a discrepancy between what 
a timeout does in normal mode versus deferrable.  
   
   When the `timeout` is reached in non-deferrable, this causes an 
[AirflowSensorTimeout](https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/tasks.html#timeouts)
 and the task fails without retrying, which is the correct behaviour IMO.  
   
   I would like to see this be consistent across ALL sensors regardless of 
whether it is running in deferrable mode or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to