Lee-W commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1451418594
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -670,10 +680,16 @@ def write_logs(self, pod: k8s.V1Pod):
def post_complete_action(self, *, pod, remote_pod, **kwargs):
"""Actions that must be done after operator finishes logic of the
deferrable_execution."""
- self.cleanup(
- pod=pod,
- remote_pod=remote_pod,
- )
+ try:
+ self.cleanup(
+ pod=pod,
+ remote_pod=remote_pod,
+ )
+ except Exception:
+ # If one task got makred as failed, it should not raise exception
which might cause retry.
+ # https://github.com/apache/airflow/issues/36471
+ if not self._killed:
+ raise
Review Comment:
Hmmm... I would say I don't really like wrapping the original exception as
an airflow exception. I use airflow exception for new customized. exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
