Taragolis commented on code in PR #36789:
URL: https://github.com/apache/airflow/pull/36789#discussion_r1452463660
##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -445,9 +445,19 @@ def __init__(
self,
*,
command: Sequence[str] = [],
+ region: str,
+ parent_model: str | None = None,
+ impersonation_chain: str | Sequence[str] | None = None,
+ dataset_id: str | None = None,
Review Comment:
Well then it better to be fixed on pre-commit level, we have half of the
Amazon provider Operators which dynamically define this parameter through
couple of parent classes, and there is a plan to migrate all of them to the
[base classes](https://github.com/apache/airflow/issues/35278) where
`aws_conn_id`, `region_name` and `verify` are templated fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
