potiuk commented on PR #36767:
URL: https://github.com/apache/airflow/pull/36767#issuecomment-1894264961

   > Nop. We can just add disclaimer that release manager have descrtion on the 
matter when we do release cut.
   
   I strongly believe this should be the case. P
   
   eople often mix the "method parameter name, or renaming the method" as being 
a sign of breaking change in SemVer. It's not as easy and straightforward - I 
will keep on repeating it. SemVer does not define that adding or removing a 
parameter is /is not breaking. They leave to discretion of those who define the 
AP  and we are pretty free to define our API as we see fit - mostly taking into 
account the usage patterns we `expect` our users will have. 
   
   And it is really hard and borderline impossible to define it
   
   a) comprehensively enough
   b) in a non-ambiguous way (which can be interpreted in various ways)
   
   As Hyrum's law (correctly IMHO) says - in a complex change pretty much any 
change is breaking someone's workflow. It's up to us to assess if such change 
is "breaking enough" to be classified as such. We shoudl communicate our 
intentions to our users and in case of doubt interpret and classify the changes 
by human - who can make a jugment, not by code that tells it objectively 
breaking/not breaking. At the end SemVer is about intentions, not about 
renaming methods.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to