pankajkoti commented on code in PR #36806:
URL: https://github.com/apache/airflow/pull/36806#discussion_r1457527454
##########
airflow/providers/microsoft/azure/triggers/wasb.py:
##########
@@ -102,26 +102,28 @@ class WasbPrefixSensorTrigger(BaseTrigger):
``copy``, ``deleted``
:param delimiter: filters objects based on the delimiter (for e.g '.csv')
:param wasb_conn_id: the connection identifier for connecting to Azure WASB
- :param poke_interval: polling period in seconds to check for the status
+ :param check_options: Optional keyword arguments that
+ `WasbAsyncHook.check_for_prefix_async()` takes.
:param public_read: whether an anonymous public read access should be
used. Default is False
+ :param poke_interval: polling period in seconds to check for the status
"""
def __init__(
self,
container_name: str,
prefix: str,
- include: list[str] | None = None,
- delimiter: str = "/",
Review Comment:
Would these arguments now need to be passed in under `check_options`? And
would this call for this PR to be included in a major release considering it
could be a breaking change(assuming we call Triggerers as public interfaces)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
