Lee-W commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1458229220
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -573,10 +575,17 @@ def execute_sync(self, context: Context):
self.pod, istio_enabled, self.base_container_name
)
finally:
- self.cleanup(
- pod=self.pod or self.pod_request_obj,
- remote_pod=self.remote_pod,
- )
+ try:
+ self.cleanup(
+ pod=self.pod or self.pod_request_obj,
+ remote_pod=self.remote_pod,
+ )
+ except Exception:
+ # If task got marked as failed, it should not raise exception
(which might cause retry).
+ # https://github.com/apache/airflow/issues/36471
+ if not self._killed:
+ raise
Review Comment:
Indeed, just move the flag to `cleanup`. If the task has been killed, we'll
not call it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
