jedcunningham commented on code in PR #36628:
URL: https://github.com/apache/airflow/pull/36628#discussion_r1459645537
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
Review Comment:
I think this was right before. If the dag processor is on, I think it makes
sense for the syncing to happen here, thus we need the key.
##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -299,11 +301,12 @@ spec:
{{- else if .Values.dags.gitSync.enabled }}
- name: dags
emptyDir: {{- toYaml (default (dict)
.Values.dags.gitSync.emptyDirConfig) | nindent 12 }}
+ {{- end }}
{{- if .Values.dags.gitSync.sshKeySecret }}
+ # unlike other pods, git-sync in scheduler is enabled even if
dag.persistence is enabled
Review Comment:
These comments aren't correct if the dag processor is enabled.
##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -299,11 +301,12 @@ spec:
{{- else if .Values.dags.gitSync.enabled }}
- name: dags
emptyDir: {{- toYaml (default (dict)
.Values.dags.gitSync.emptyDirConfig) | nindent 12 }}
+ {{- end }}
{{- if .Values.dags.gitSync.sshKeySecret }}
Review Comment:
```suggestion
{{- if and $localOrDagProcessorDisabled .Values.dags.gitSync.enabled
.Values.dags.gitSync.sshKeySecret }}
```
It think this, in addition to your other changes in this file, is the right
fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
