potiuk commented on a change in pull request #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI URL: https://github.com/apache/airflow/pull/5837#discussion_r316486707
########## File path: Dockerfile ########## @@ -372,4 +397,6 @@ EXPOSE 8080 ENTRYPOINT ["/usr/local/bin/dumb-init", "--", "/entrypoint.sh"] +VOLUME /var/lib/docker Review comment: Why do we need that? It's not obvious what is going on here and why we need it here. If we need it for a specific reason, we should explain it in the comment. If I am guessing correctly, this is to make DinD work for Travis so that we use the same docker engine (as DockerInDocker) as we use in Travis? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
