dirrao commented on code in PR #36882: URL: https://github.com/apache/airflow/pull/36882#discussion_r1463613047
########## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ########## @@ -434,9 +434,9 @@ def sync(self) -> None: ) self.fail(task[0], e) except ApiException as e: - # These codes indicate something is wrong with pod definition; otherwise we assume pod - # definition is ok, and that retrying may work - if e.status in (400, 422): + # In case of the below error codes, fail the task and honor the task retires. + # Otherwise, go for continuous/infinite retries. + if e.status in (400, 403, 404, 422): Review Comment: Yes. It's a breaking change. If we do the right thing, then I believe it's okay to introduce it in the major version release. The question is about retaining the old behavior, not the implementation. ########## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ########## @@ -434,9 +434,9 @@ def sync(self) -> None: ) self.fail(task[0], e) except ApiException as e: - # These codes indicate something is wrong with pod definition; otherwise we assume pod - # definition is ok, and that retrying may work - if e.status in (400, 422): + # In case of the below error codes, fail the task and honor the task retires. + # Otherwise, go for continuous/infinite retries. + if e.status in (400, 403, 404, 422): Review Comment: Yes. It's a breaking change. If we do the right thing, then I believe it's okay to introduce it in the major version release. The question is about retaining the old behavior, not the implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org