Lee-W commented on PR #36968: URL: https://github.com/apache/airflow/pull/36968#issuecomment-1907162041
> I'm not totally convinced this is the best fix. Per my [comment](https://github.com/apache/airflow/issues/36957#issue-2094747829) I don't think `@Sentry.enrich_errors` makes sense on `_schedule_downstream_tasks`. The task is already wrapped by `@Sentry.enrich_errors` [in `_run_raw_task`](https://github.com/apache/airflow/blob/2.8.0/airflow/models/taskinstance.py#L2280) and the task being passed to `_schedule_downstream_tasks` is not being run again: it's downstream tasks will be scheduled and again wrapped by `@Sentry.enrich_errors` within [`_run_raw_task`](https://github.com/apache/airflow/blob/2.8.0/airflow/models/taskinstance.py#L2280) I thought we still wanted to have enriched errors when we scheduled the tasks because errors might also occur at scheduling time. But I too don't have the full context of why this was designed this way back then 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
