koushik-rout-samsung commented on code in PR #36526: URL: https://github.com/apache/airflow/pull/36526#discussion_r1464326882
########## airflow/config_templates/config.yml: ########## @@ -583,11 +583,15 @@ database: description: | Import path for connect args in SqlAlchemy. Defaults to an empty dict. This is useful when you want to configure db engine args that SqlAlchemy won't parse - in connection string. - See https://docs.sqlalchemy.org/en/14/core/engines.html#sqlalchemy.create_engine.params.connect_args + in connection string. This can be set by passing a dictionary containing the create engine parameters. + For more details about passing create engine parameters(keepalives variables, timeout etc) + in postgres db connection see + https://airflow.apache.org/docs/apache-airflow/stable/howto/set-up-database.html#setting-up-a-postgresql-database + Example: connect_args={"timeout":30} can be defined in airflow_local_settings.py and + can be imported as shown below version_added: 2.3.0 type: string - example: '{"timeout": 30}' + example: 'airflow_local_settings.connect_args' Review Comment: No, its actually an example. ########## airflow/config_templates/config.yml: ########## @@ -583,11 +583,15 @@ database: description: | Import path for connect args in SqlAlchemy. Defaults to an empty dict. This is useful when you want to configure db engine args that SqlAlchemy won't parse - in connection string. - See https://docs.sqlalchemy.org/en/14/core/engines.html#sqlalchemy.create_engine.params.connect_args + in connection string. This can be set by passing a dictionary containing the create engine parameters. + For more details about passing create engine parameters(keepalives variables, timeout etc) Review Comment: Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org