potiuk commented on PR #36991: URL: https://github.com/apache/airflow/pull/36991#issuecomment-1908828287
> @potiuk anything else needed from me at this time? I assume you guys have the testing handled from here No - unit tests are always part of the PRs. We have separately run tests for the helm chart in `helm_tests` folder which are basically testing that when you set the right parameter, the resources are produced properly after passing throuhg helm. Our contributig guide is currently not properly rendered by github, but I have a PR in progress where all the contributing docs ( are nicely split to smaller docs, so you can see the docs nicely rendering here https://github.com/apache/airflow/blob/refactor-contributing-docs/contributing-docs/testing/helm_unit_tests.rst and you can look at other tests in `helm_tests` and add your tests in similar way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
