potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1466168117
########## README.md: ########## @@ -426,13 +427,22 @@ might decide to add additional limits (and justify them with comment). ## Contributing -Want to help build Apache Airflow? Check out our [contributing documentation](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst). +Want to help build Apache Airflow? Check out our [contributing documentation](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst). Official Docker (container) images for Apache Airflow are described in [IMAGES.rst](https://github.com/apache/airflow/blob/main/IMAGES.rst). <!-- END Contributing, please keep comment here to allow auto update of PyPI readme.md --> <!-- START Who uses Apache Airflow, please keep comment here to allow auto update of PyPI readme.md --> +## Commit Policy + +* Commits need a +1 vote from a committer who is not the author Review Comment: I think we have to live with the dualism `maintainer` and `comitter`. While for all practical purposes they are the same, the context is a bit different. I think it's worth explaining, so I added a chapter in the `committers.rst` documentation: ``` Committers vs. Maintainers -------------------------- Often you can hear two different terms about people who have write access to the Airflow repository - "committers" and "maintainers". This is because those two terms are used in different contexts. * "Maintainers" is term used in GitHub documentation and configuration and is a generic term referring to people who have write access to the repository. They can merge PRs, push to the repository, etc. * "Committers" is a term used in Apache Software Foundation (ASF) and is a term referring to people who have write access to the code repository and has a signed [Contributor License Agreement (CLA)](https://www.apache.org/licenses/#clas) on file. They have an apache.org mail address. This is an official [role](https://www.apache.org/foundation/how-it-works/#roles) defined and governed by the Apache Software Foundation. For all practical purposes, both terms are interchangeable because the Apache Software Foundation rule is the only Committers can have write access to the repositories managed by the PMC (Project Management Committee) and that all Committers get write access to the repository. You will see both terms used in different documentation, therefore our goal is not to use one of the terms only - it is unavoidable to see both terms anyway. As a rule, we are using "committer" term in the context of the official rules concerning Apache Software Foundation and "maintainer" term in the context where technical GitHub access and permissions to the project are important. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
