potiuk commented on PR #37015: URL: https://github.com/apache/airflow/pull/37015#issuecomment-1911143165
Yeah. I thought a bit about it and I think reverting is the fastest and most secure way. This way we can release RC2 now, and properly get it implemented and tested. There are a bit unexpected scenarios, where passing **kwargs is a bad idea. I think ince BaseHook does not take **kwargs, we cannot just pass the kwargs if we want to support all the scenarios explaied in the https://github.com/apache/airflow/issues/36948#issuecomment-1910279616 I will revert and re-release the next wave with accelerated voring, and we should implement the log_name as specific, new parameter for all the hooks and get common sanitization pattern. Having **kwargs supported in "blanket" way and passing it down to the BaseHook that does not support **kwargs opens up to too many potential issues. BTW. @eladkal is flying tonight and he asked me to take over - so I will take it from here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
