potiuk opened a new pull request, #37052:
URL: https://github.com/apache/airflow/pull/37052

   The "generated/provider_dependencies.json" is regenerated automatically 
together with pyproject.toml from all the provider.yaml files. The file 
contains information about dependencies for all providers and it is used to 
determine a number of actions when we build providers (for example it is used 
to automatically generated cross-provider dependencies, and determine whether 
provider is ready to be released)
   
   The "dependencies" from provider_dependencies.json are also reflected in 
pyproject.toml file in order to determine what should be installed when you 
install specific editable extra, so pyproject.toml is also generated 
automatically together with
   provider_dependencies.json. All is good when that generation is done 
automatically, but so far, when you updated provider_dependencies.json 
manually, the pyproject.toml was not regenerated - it was actually skipped from 
regeneration.
   
   This PR changes it by storing hash of provider_depenedencies.json (mixed 
with the has of the script that generates them) in the generated pyproject.toml 
file. This way, both - provider_dependencies and pyproject.toml wil always be 
regenerated by the
   "update_providers_dependencies.py" pre-commit whenever there is any 
inconsistency between provider.yaml files, provider_dependencies.json or 
pyproject.toml.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to