potiuk commented on code in PR #37058:
URL: https://github.com/apache/airflow/pull/37058#discussion_r1468902862
##########
airflow/config_templates/config.yml:
##########
@@ -375,6 +375,21 @@ core:
type: string
example: "path.to.CustomXCom"
default: "airflow.models.xcom.BaseXCom"
+ xcom_objectstorage_path:
+ description: |
+ Path to a location on object storage where XComs can be stored in url
format.
+ version_added: 2.9.0
+ type: string
+ example: "s3://conn_id@bucket/path"
+ default: ""
+ xcom_objectstorage_threshold:
+ description: |
+ Threshold in bytes for storing XComs in object storage.
Review Comment:
Would be nice to specify behaviour for `-1` - from default it looks like it
is intended for `-1` to mean no threasholdm but also 0 could be one (0 feels a
bit more intuitive, but if it's explicitly stated that `-1` makes all data
stored in object storage, then -1 is a also good. It's of course logically
correct (with exceeds and figuring out what happens when you have 0-sized
object), but spelling it out explicitly would save the mental effort to figure
it out by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
