potiuk commented on code in PR #36953: URL: https://github.com/apache/airflow/pull/36953#discussion_r1468925306
########## airflow/providers/teradata/example_dags/example_teradata_operator.py: ########## @@ -0,0 +1,132 @@ +# Review Comment: example_dags = system_tests. The system tests have three purposes, that's why they should be combined: * system tests runnable and exposed via test dashboard * example dags that people can copy and start with directly from GitHub * the excerpts of the examples are embedded in Howto documentation This way there is only one place where those examples/system tests are defined and there is much higher probability they will be kept in a good state when things change because for example mypy / ruff/ linting will check them for correctness and hipefully system test dashboard will keep them running in Green state That's why all of those should be merged and kept in `tests/system` and they should be referred to in the howto documentation - you can take a look at google provider or amazon provider for example to see how it is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
