uranusjr commented on code in PR #36797:
URL: https://github.com/apache/airflow/pull/36797#discussion_r1469118016


##########
airflow/serialization/serialized_objects.py:
##########
@@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) 
-> Operator:
                 task_group=None,
                 start_date=None,
                 end_date=None,
+                map_index_template=MappedOperator.map_index_template,

Review Comment:
   `MappedOperator.map_index_template` should exist, but I don’t think it would 
hold the correct value. Our goal here is to make the value per-task, but this 
attribute holds the class-wide value instead.
   
   The value should get filled into `encoded_op` in `serialize_mapped_operator` 
(more specifically, in one of the functions that function calls). We should 
check why the field is not filled into the dict, and fix that accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to