potiuk commented on PR #37055: URL: https://github.com/apache/airflow/pull/37055#issuecomment-1915824822
> Now that you explicitly fail if both parameters are specified, you could potentially simplify this statement: `if self.max_rows_per_file and not self.groupby_kwargs:` But I'll leave that up to you :) Yeah. Thought about that too, but now it is very explicit as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org