molcay opened a new pull request, #37087:
URL: https://github.com/apache/airflow/pull/37087
Add new run type "triggered" to distinguish manual DAG runs and triggered
DAG runs (`TriggerDagRunOperator`).
### Justification to introduce a new RunType
Before this improvement, we were prepending the run id with the string
"manual" for `TriggerDagRunOperator` as well as manual run (which can be
started on UI). This can cause a misunderstanding when we look for the logs and
also for the UI. We did not have a way to distinguish **manual runs** and the
**triggered runs** (which can be done with `TriggerDagRunOperator`).
To accomplish this, I introduced the followings:
- A new RunType value:
```python3
TRIGGERED = "triggered"
```
- A new icon for UI:
```typescript
import { MdBolt } from "react-icons/md";
// ...
case "triggered":
return <MdBolt style={iconStyle} {...rest} />;
//...
```
which is look likes the following (in action):
> Of course, we can change the icon with another icon that can be more
suitable but as a entry point, I selected this one.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
