potiuk commented on code in PR #37060: URL: https://github.com/apache/airflow/pull/37060#discussion_r1471012125
########## airflow/providers/amazon/provider.yaml: ########## @@ -118,10 +118,7 @@ additional-extras: devel-dependencies: - aiobotocore>=2.7.0 - aws_xray_sdk>=2.12.0 - # Moto 5 replaced all decorators with single mock_aws decorator and we need to - # Replace the usage of mock decorators in our tests to be able to use moto 5 - # See https://github.com/apache/airflow/issues/37053 - - moto[cloudformation,glue]>=4.2.12,<5.0.0 + - moto[cloudformation,glue]>=5.0.0 Review Comment: Agree with @Taragolis . With devel-only dependencies it's perfectly fine to "move fast/break things". Since we are fully in control of the environment and we make sure that it is correct and we even expect our contributors in main to have exactly the same set of dependencies as everyone else. This is why we have constraints, so generally we should be ok even if with every single commit we add `>= <current constraint version of the dependency>`. That would be even good as it would force anyone to get the `proper` versions of their development environment which is "same as everyone else" - but yeah, that would be an exaggeration. In the new PEP-compliant world and our hatchling backend, those `devel-dependencies` are even stripped out automatically (by our hatchling build hooks) from the "user-facing" wheel, so it has exactly 0 impact on users, it only affects those who contribute to airflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
