o-nikolas commented on code in PR #37137:
URL: https://github.com/apache/airflow/pull/37137#discussion_r1475312683
##########
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##########
@@ -406,17 +407,17 @@ def _run_task_kwargs(
One last chance to modify Boto3's "run_task" kwarg params before it
gets passed into the Boto3 client.
"""
- run_task_api = deepcopy(self.run_task_kwargs)
- container_override =
self.get_container(run_task_api["overrides"]["containerOverrides"])
+ run_task_kwargs = deepcopy(self.run_task_kwargs)
+ run_task_kwargs = merge_dicts(run_task_kwargs, exec_config)
Review Comment:
I think it's nice because I don't know who will possibly mettle with that
helper function in the future. But I also see your point. Happy to remove it if
you feel strongly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
