Taragolis commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1925734979
I guess not yet, at least if I uncomment this line https://github.com/apache/airflow/blob/f24a03709eecbda87ed794cee567806e51c3a21f/pyproject.toml#L1276 And run check manually I've got an error: ```console Run 'ruff' for extremely fast Python linting.............................Failed - hook id: ruff - exit code: 1 airflow/auth/managers/utils/fab.py:43:5: D401 First line of docstring should be in imperative mood: "Returns the map associating a method to a FAB action." airflow/auth/managers/utils/fab.py:48:5: D401 First line of docstring should be in imperative mood: "Returns the map associating a FAB action to a method." ... (truncated about 1000 lines) airflow/www/auth.py:90:5: D401 First line of docstring should be in imperative mood: "This decorator is used to check permissions on views." airflow/www/auth.py:348:5: D401 First line of docstring should be in imperative mood: "Decorator that checks current user's permissions to access the website." airflow/www/blueprints.py:27:5: D401 First line of docstring should be in imperative mood: "Main Airflow page." airflow/www/views.py:4067:9: D401 First line of docstring should be in imperative mood: "Action method to handle multiple records selected from a list view." Found 1084 errors. ``` I assume it is pretty hard to implement it until https://github.com/astral-sh/ruff/issues/3172 not implemented. 1. Someone fix doc strings into the entire module/components 2. Couple days after someone add new docstring which not follow D401 3. 😢 As solution for that we might enable D401 by default in ruff and add current files/module which not yet follow D401 into the `tool.ruff.per-file-ignores`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
