eladkal commented on issue #36994:
URL: https://github.com/apache/airflow/issues/36994#issuecomment-1929880837

   
   > To be fair, this is becoming a lot more complicated
   
   I belive its complicated because you are combining the business logic of the 
dag with adminstative operation of upgrade. DAG author should not have business 
logic impacted (on/off) because cluster admin decided to make an upgrade. 
Meaning that if you switch my dag to off for upgrade then you need to turn it 
on once upgrade is done how would you do that for a deployemnt of 1000 dags 
authored by 200 different developers?
   
   I think you are consedring only deployments where the dag author and the 
cluster admin are the same person :)
   This is why I say it is a dangerous operation and since the use case you 
described is for upgrade I suggested to not make it a UI button but API call.
   
   I am happy to discuss ideas of how to accommodate your request but you need 
to understand that we have to consider all kinds of deployments and the 
implication of such button would make.
   
   I would be more happy with adding such operation on a folder base rather 
than all dags once https://github.com/apache/airflow/issues/24464 is 
implemented.
   
   (On side note I still don't quite follow why termination of scheduler is not 
good enough to handle your use case)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to