utkarsharma2 commented on code in PR #37192:
URL: https://github.com/apache/airflow/pull/37192#discussion_r1481084182


##########
tests/providers/google/cloud/hooks/test_compute_ssh.py:
##########
@@ -162,7 +162,9 @@ def test_get_conn_authorize_using_instance_metadata(
         mock_compute_hook.return_value.project_id = TEST_PROJECT_ID
         mock_compute_hook.return_value.get_instance_address.return_value = 
EXTERNAL_IP
 
-        mock_compute_hook.return_value.get_instance_info.return_value = 
{"metadata": {}}
+        mock_compute_hook.return_value.get_instance_info.return_value = {
+            "metadata": {"items": [{"key": "foo", "value": "bar"}]}

Review Comment:
   The new test case looks good. I think we don't need any changes to the old 
one, WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to