This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 2bc8e175b3 Add d401 support to snowflake provider (#37299)
2bc8e175b3 is described below
commit 2bc8e175b3a4cc84fe33e687f1a00d2a49563090
Author: Rohit Gupta <[email protected]>
AuthorDate: Sat Feb 10 16:28:08 2024 +0530
Add d401 support to snowflake provider (#37299)
---
airflow/providers/snowflake/hooks/snowflake.py | 10 +++++-----
airflow/providers/snowflake/hooks/snowflake_sql_api.py | 4 ++--
airflow/providers/snowflake/operators/snowflake.py | 2 +-
airflow/providers/snowflake/transfers/copy_into_snowflake.py | 2 +-
airflow/providers/snowflake/triggers/snowflake_trigger.py | 2 +-
airflow/providers/snowflake/utils/sql_api_generate_jwt.py | 2 +-
pyproject.toml | 6 ------
7 files changed, 11 insertions(+), 17 deletions(-)
diff --git a/airflow/providers/snowflake/hooks/snowflake.py
b/airflow/providers/snowflake/hooks/snowflake.py
index 2e71675cda..90d0ac9a42 100644
--- a/airflow/providers/snowflake/hooks/snowflake.py
+++ b/airflow/providers/snowflake/hooks/snowflake.py
@@ -92,7 +92,7 @@ class SnowflakeHook(DbApiHook):
@classmethod
def get_connection_form_widgets(cls) -> dict[str, Any]:
- """Returns connection widgets to add to connection form."""
+ """Return connection widgets to add to connection form."""
from flask_appbuilder.fieldwidgets import BS3TextAreaFieldWidget,
BS3TextFieldWidget
from flask_babel import lazy_gettext
from wtforms import BooleanField, StringField
@@ -114,7 +114,7 @@ class SnowflakeHook(DbApiHook):
@classmethod
def get_ui_field_behaviour(cls) -> dict[str, Any]:
- """Returns custom field behaviour."""
+ """Return custom field behaviour."""
import json
return {
@@ -273,7 +273,7 @@ class SnowflakeHook(DbApiHook):
)
def get_conn(self) -> SnowflakeConnection:
- """Returns a snowflake.connection object."""
+ """Return a snowflake.connection object."""
conn_config = self._get_conn_params()
conn = connector.connect(**conn_config)
return conn
@@ -338,7 +338,7 @@ class SnowflakeHook(DbApiHook):
return_last: bool = True,
return_dictionaries: bool = False,
) -> tuple | list[tuple] | list[list[tuple] | tuple] | None:
- """Runs a command or a list of commands.
+ """Run a command or list of commands.
Pass a list of SQL statements to the SQL parameter to get them to
execute sequentially. The variable ``execution_info`` is returned so
@@ -454,7 +454,7 @@ class SnowflakeHook(DbApiHook):
def get_openlineage_default_schema(self) -> str | None:
"""
- Attempts to get current schema.
+ Attempt to get current schema.
Usually ``SELECT CURRENT_SCHEMA();`` should work.
However, apparently you may set ``database`` without ``schema``
diff --git a/airflow/providers/snowflake/hooks/snowflake_sql_api.py
b/airflow/providers/snowflake/hooks/snowflake_sql_api.py
index 962f5ebd4c..9d564144d1 100644
--- a/airflow/providers/snowflake/hooks/snowflake_sql_api.py
+++ b/airflow/providers/snowflake/hooks/snowflake_sql_api.py
@@ -82,7 +82,7 @@ class SnowflakeSqlApiHook(SnowflakeHook):
self.private_key: Any = None
def get_private_key(self) -> None:
- """Gets the private key from snowflake connection."""
+ """Get the private key from snowflake connection."""
conn = self.get_connection(self.snowflake_conn_id)
# If private_key_file is specified in the extra json, load the
contents of the file as a private key.
@@ -122,7 +122,7 @@ class SnowflakeSqlApiHook(SnowflakeHook):
self, sql: str, statement_count: int, query_tag: str = "", bindings:
dict[str, Any] | None = None
) -> list[str]:
"""
- Using SnowflakeSQL API, run the query in snowflake by making API
request.
+ Run the query in Snowflake using SnowflakeSQL API by making API
request.
:param sql: the sql string to be executed with possibly multiple
statements
:param statement_count: set the MULTI_STATEMENT_COUNT field to the
number of SQL statements
diff --git a/airflow/providers/snowflake/operators/snowflake.py
b/airflow/providers/snowflake/operators/snowflake.py
index 6bb479e486..2de40bc04d 100644
--- a/airflow/providers/snowflake/operators/snowflake.py
+++ b/airflow/providers/snowflake/operators/snowflake.py
@@ -573,7 +573,7 @@ class SnowflakeSqlApiOperator(SQLExecuteQueryOperator):
def execute_complete(self, context: Context, event: dict[str, str |
list[str]] | None = None) -> None:
"""
- Callback for when the trigger fires - returns immediately.
+ Execute callback when the trigger fires; returns immediately.
Relies on trigger to throw an exception, otherwise it assumes
execution was successful.
"""
diff --git a/airflow/providers/snowflake/transfers/copy_into_snowflake.py
b/airflow/providers/snowflake/transfers/copy_into_snowflake.py
index 342d5dc35a..0048637bf0 100644
--- a/airflow/providers/snowflake/transfers/copy_into_snowflake.py
+++ b/airflow/providers/snowflake/transfers/copy_into_snowflake.py
@@ -153,7 +153,7 @@ class
CopyFromExternalStageToSnowflakeOperator(BaseOperator):
def _extract_openlineage_unique_dataset_paths(
query_result: list[dict[str, Any]],
) -> tuple[list[tuple[str, str]], list[str]]:
- """Extracts and returns unique OpenLineage dataset paths and file
paths that failed to be parsed.
+ """Extract and return unique OpenLineage dataset paths and file paths
that failed to be parsed.
Each row in the results is expected to have a 'file' field, which is a
URI.
The function parses these URIs and constructs a set of unique
OpenLineage (namespace, name) tuples.
diff --git a/airflow/providers/snowflake/triggers/snowflake_trigger.py
b/airflow/providers/snowflake/triggers/snowflake_trigger.py
index 32ed855325..48d4c35626 100644
--- a/airflow/providers/snowflake/triggers/snowflake_trigger.py
+++ b/airflow/providers/snowflake/triggers/snowflake_trigger.py
@@ -53,7 +53,7 @@ class SnowflakeSqlApiTrigger(BaseTrigger):
self.token_renewal_delta = token_renewal_delta
def serialize(self) -> tuple[str, dict[str, Any]]:
- """Serializes SnowflakeSqlApiTrigger arguments and classpath."""
+ """Serialize SnowflakeSqlApiTrigger arguments and classpath."""
return (
"airflow.providers.snowflake.triggers.snowflake_trigger.SnowflakeSqlApiTrigger",
{
diff --git a/airflow/providers/snowflake/utils/sql_api_generate_jwt.py
b/airflow/providers/snowflake/utils/sql_api_generate_jwt.py
index f1eb2ed6c2..47558f1a1f 100644
--- a/airflow/providers/snowflake/utils/sql_api_generate_jwt.py
+++ b/airflow/providers/snowflake/utils/sql_api_generate_jwt.py
@@ -111,7 +111,7 @@ class JWTGenerator:
def get_token(self) -> str | None:
"""
- Generates a new JWT.
+ Generate a new JWT.
If a JWT has been already been generated earlier, return the previously
generated token unless the specified renewal time has passed.
diff --git a/pyproject.toml b/pyproject.toml
index 288ce8053e..f93cd2aeb6 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1551,12 +1551,6 @@ combine-as-imports = true
"airflow/providers/slack/hooks/slack_webhook.py" = ["D401"]
"airflow/providers/slack/operators/slack.py" = ["D401"]
"airflow/providers/smtp/hooks/smtp.py" = ["D401"]
-"airflow/providers/snowflake/hooks/snowflake.py" = ["D401"]
-"airflow/providers/snowflake/hooks/snowflake_sql_api.py" = ["D401"]
-"airflow/providers/snowflake/operators/snowflake.py" = ["D401"]
-"airflow/providers/snowflake/transfers/copy_into_snowflake.py" = ["D401"]
-"airflow/providers/snowflake/triggers/snowflake_trigger.py" = ["D401"]
-"airflow/providers/snowflake/utils/sql_api_generate_jwt.py" = ["D401"]
"airflow/providers/tableau/hooks/tableau.py" = ["D401"]
"airflow/providers/tableau/operators/tableau.py" = ["D401"]
"airflow/providers/telegram/hooks/telegram.py" = ["D401"]