hussein-awala commented on code in PR #37316:
URL: https://github.com/apache/airflow/pull/37316#discussion_r1485334278
##########
airflow/www/forms.py:
##########
@@ -234,13 +234,42 @@ def process(self, formdata=None, obj=None, **kwargs):
"corresponding Airflow Provider Package."
),
)
- description = StringField(lazy_gettext("Description"),
widget=BS3TextAreaFieldWidget())
- host = StringField(lazy_gettext("Host"), widget=BS3TextFieldWidget())
- schema = StringField(lazy_gettext("Schema"),
widget=BS3TextFieldWidget())
- login = StringField(lazy_gettext("Login"), widget=BS3TextFieldWidget())
- password = PasswordField(lazy_gettext("Password"),
widget=BS3PasswordFieldWidget())
- port = IntegerField(lazy_gettext("Port"), validators=[Optional()],
widget=BS3TextFieldWidget())
- extra = TextAreaField(lazy_gettext("Extra"),
widget=BS3TextAreaFieldWidget())
+
+ description = StringField(
+ lazy_gettext("Description"),
+ widget=BS3TextAreaFieldWidget(),
+ validators=[NoHTMLTags()],
+ )
+ host = StringField(
+ lazy_gettext("Host"),
+ widget=BS3TextFieldWidget(),
+ validators=[NoHTMLTags()],
+ )
+ schema = StringField(
+ lazy_gettext("Schema"),
+ widget=BS3TextFieldWidget(),
+ validators=[NoHTMLTags()],
+ )
+ login = StringField(
+ lazy_gettext("Login"),
+ widget=BS3TextFieldWidget(),
+ validators=[NoHTMLTags()],
+ )
+ password = PasswordField(
+ lazy_gettext("Password"),
+ widget=BS3PasswordFieldWidget(),
+ validators=[NoHTMLTags()],
+ )
+ port = IntegerField(
+ lazy_gettext("Port"),
+ validators=[Optional()],
+ widget=BS3TextFieldWidget(),
+ )
+ extra = TextAreaField(
Review Comment:
Just checked the issue and found:
> Also when they do, they should be escaped when rendered on HTML pages.
Also, I'm wondering if some users need to pass HTML via extra; should we
block that completely or just stop rendering the HTML by escaping them on the
connection web UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]