Taragolis commented on code in PR #37330: URL: https://github.com/apache/airflow/pull/37330#discussion_r1485592414
########## airflow/providers/qdrant/__init__.py: ########## @@ -14,3 +14,29 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +# +# NOTE! THIS FILE IS AUTOMATICALLY GENERATED AND WILL BE +# OVERWRITTEN WHEN PREPARING DOCUMENTATION FOR THE PACKAGES. +# +# IF YOU WANT TO MODIFY THIS FILE, YOU SHOULD MODIFY THE TEMPLATE +# `PROVIDER__INIT__PY_TEMPLATE.py.jinja2` IN the `dev/breeze/src/airflow_breeze/templates` DIRECTORY +# +from __future__ import annotations + +import packaging.version + +__all__ = ["__version__"] + +__version__ = "1.0.0" + +try: + from airflow import __version__ as airflow_version +except ImportError: + from airflow.version import version as airflow_version + +if packaging.version.parse(packaging.version.parse(airflow_version).base_version) < packaging.version.parse( Review Comment: I always confused by this long construction, I guess it comes from the fact that we have to lax requirement to `packaging` https://github.com/apache/airflow/blob/9a10085bb142df8a7699cd66908f1896ae10b5bb/pyproject.toml#L120-L120 `packaging` 14 was released in 2018: https://pypi.org/project/packaging/#history So I guess we could bump min version to something new, e.g. >= 22 or eve 23, and one day replace this to ```python from packaging.version import Version ... if Version(Version(airflow_version).base_version) < Version("2.6.0"): raise ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
