dacort commented on code in PR #34225:
URL: https://github.com/apache/airflow/pull/34225#discussion_r1486816359
##########
airflow/providers/amazon/aws/links/emr.py:
##########
@@ -66,3 +82,111 @@ def get_log_uri(
return None
log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])
return "/".join(log_uri)
+
+
+class EmrServerlessLogsLink(BaseAwsLink):
Review Comment:
I'm having a little bit of trouble mocking the EMR Serverless client. In
`EmrServerlessLogsLink` for example, I'm creating a new hook and then calling
`hook.conn.get_dashboard_for_job_run`.
I see that in `test_get_log_uri` method, a mock `emr_client` is actually
passed in...I wonder if I should restructure the `get_dashboard_for_job_run`
methods in the `EmrServerless*Link` classes to do the same? With your other
comments below, that probably makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
