bolkedebruin commented on PR #37168:
URL: https://github.com/apache/airflow/pull/37168#issuecomment-1948021295

   > We do need to specify the classname, which should be "builtins.tuple":
   > 
   > The `serialize` method (in 
[airflow/serialization/serializers/builtin.py](https://github.com/apache/airflow/blob/main/airflow/serialization/serializers/builtin.py#L34-L35))
 does `qualname()` on the namedtuple, which returns 
"[airflow.providers.databricks.hooks.Row](https://github.com/apache/airflow/blob/7f64dacadbfabbf4a5a0fab90321d387a0d66232/airflow/providers/odbc/hooks/odbc.py#L241)"
 (the namedtuple dynamically created in the hook). If this is used as 
classname, it will fail to deserialize: there won't be any deserializer for it.
   > 
   > If we hardcode it to "builtins.tuple", it gets deserialized correctly.
   
   Ah sorry @Joffreybvn , I missed that. If you'd like you can revert to the 
previous / earlier version. That looks and reads better. Add a comment that you 
are overriding the class name and it makes things clear


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to