vincbeck commented on PR #37549: URL: https://github.com/apache/airflow/pull/37549#issuecomment-1953266625
> > Looks like this was what lead to the false positive earlier. Thanks +1 > > We still have to update our FAB / WWW test suite - to make the needed test purely AuthManager ones, but that's something for another day (And likely maybe we will need to get some "TestAuthiManager" in those tests maybe (@vincbeck ?) . I think there is a number of FAB-bound tests we still have in tests/www that actually use FAB logic under-the hood, some of them we can move to provider, but likely some of them should test a generic AuthManager features so maybe some day (not today likely) we should have a general cleanup in those tests and separate the "pure" auth manager tests from the "fab" ones. > > WDYT @vincbeck ? 100% agree. I realized that when I was working on migrating FAB related code from core Airflow to providers. The only reason why I did not do it was the effort required. As mentioned by Jarek, there are many tests in core that use FAB logic, ideally we should make these tests FAB agnostic. But it won happen in one day, let's do it step by step :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
