pankajkoti commented on code in PR #37546:
URL: https://github.com/apache/airflow/pull/37546#discussion_r1495238810


##########
airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -254,6 +254,7 @@ async def _wait_for_container_completion(self) -> 
TriggerEvent:
                         "message": "Container state failed",
                     }
                 )
+            self.log.info("Container is not completed and still working.")

Review Comment:
   I had initially opened up this PR due to a comment here 
https://github.com/apache/airflow/issues/37534#issuecomment-1952355153, but 
later they said they had some misconfig or confusioin 
https://github.com/apache/airflow/issues/37534#issuecomment-1953072614



##########
airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -254,6 +254,7 @@ async def _wait_for_container_completion(self) -> 
TriggerEvent:
                         "message": "Container state failed",
                     }
                 )
+            self.log.info("Container is not completed and still working.")

Review Comment:
   I had initially opened up this PR due to a comment here 
https://github.com/apache/airflow/issues/37534#issuecomment-1952355153, but 
later they said they had some misconfig or confusion 
https://github.com/apache/airflow/issues/37534#issuecomment-1953072614



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to