potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496361617
########## airflow/utils/orm_event_handlers.py: ########## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy import __version__ as sqlalchemy_version, event, exc from airflow.configuration import conf log = logging.getLogger(__name__) +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") + def setup_event_handlers(engine): """Setups event handlers.""" from airflow.models import import_all_models - event.listen(sqlalchemy.orm.mapper, "before_configured", import_all_models, once=True) + event.listen( + sqlalchemy.orm.mapper if SQL_ALCHEMY_V1 else sqlalchemy.orm.Mapper, Review Comment: ```python def is_installed_lib_major_version(libname: str, version: int) -> bool: return parse_version(version(lib_name)).major == version ``` Or possibly even avoid common another common utility but simply use that `one liner` everywhere (if it works also for various python versions - there is a good reason why we were checking for importlib in the previous solution) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org