potiuk commented on PR #37545:
URL: https://github.com/apache/airflow/pull/37545#issuecomment-1955260813
Well - it was you who proposed to do something common between pydantic and
sqlachemy so you expanded scope and discussions yourself, so yes it took longer
and had more twists.
I thinl up until then there was only one extra suggestion from TP so that
you move things to sqlalchemy. If you need exact instructions here it is:
* do not make DRY code between Pydantic and sqlalchemy and pydantic at all.
You can have separate PR for that f you want
* move the code to check sqlalchemy to utils.sqlalchemy
And yes, it happens and is expected. Sometimes small prs takes days or weeks
and you will get different twists along the way and people looking at what you
propose will have different opinions. And sometimes it get few iterations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
