haoliang7 commented on issue #5495: [AIRFLOW-4858] Deprecate "Historical 
convenience functions" in conf
URL: https://github.com/apache/airflow/pull/5495#issuecomment-524637187
 
 
   > The change was a little bit bigger than needed 
(`configuration.conf.getboolean` was fine) but making it all consistent is no 
bad thing.
   > 
   > One small comment (on the warnings filter) then this looks good to me, 
thanks.
   > 
   > (Sorry, it's conflicted again, I didn't see the ping because my inbox is 
currently 1k deep in unread airflow messages 😉 )
   
   @ashb The conflicts have been resolved. The warnings filter was a mistake 
that has been corrected.  Please kindly review again. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to