dstandish commented on code in PR #37570:
URL: https://github.com/apache/airflow/pull/37570#discussion_r1499630671
##########
airflow/www/static/js/components/Table/Cells.tsx:
##########
@@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }:
CellProps) => {
const { sourceRunId, sourceDagId, sourceMapIndex } = row.original;
const gridUrl = getMetaValue("grid_url");
const dagId = getMetaValue("dag_id");
+ if (!value || !sourceRunId || !sourceDagId || !gridUrl) {
Review Comment:
perhaps we need to find a way to show that it is from the API
##########
airflow/api_connexion/endpoints/dataset_endpoint.py:
##########
@@ -311,3 +323,37 @@ def delete_dataset_queued_events(
"Queue event not found",
detail=f"Queue event with dataset uri: `{uri}` was not found",
)
+
+
+@security.requires_access_dataset("POST")
+@provide_session
+@action_logging(
+ event=action_event_from_permission(
+ prefix=RESOURCE_EVENT_PREFIX,
+ permission=permissions.ACTION_CAN_CREATE,
+ ),
+)
+def post_dataset_event(session: Session = NEW_SESSION) -> APIResponse:
+ """Post dataset event."""
Review Comment:
i think this function should have a better name. POST is the http method
that is connected to this function. but it doesn't tell us what this method
does.
i assume what it does is `create_dataset_event`? that would seem to be a
better name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
