potiuk edited a comment on issue #5828: [AIRFLOW-5226] Consistent licences for 
all jinja templates
URL: https://github.com/apache/airflow/pull/5828#issuecomment-524927016
 
 
   Are you OK to merge @mik-laj @ashb. I solved the problem of duplicate 
licences now - the modified version of the insert-license plugin is now taken 
from my repo and it's much smarter now + it informs which files were modified + 
you can disable license insertion for files via appropriate comment. Lots of 
tests added . I tested it on the parent of this commit and it correctly added 
new licenses and TODOs where licences were inconsistent with this comment:
   
   ```
   --- a/airflow/www/templates/appbuilder/flash.html
   +++ b/airflow/www/templates/appbuilder/flash.html
   @@ -1,4 +1,6 @@
    {#
   + TODO: This license is not consistent with license used in the project.
   +       Delete the inconsistent license and above line and rerun pre-commit 
to insert good license.
      Licensed to the Apache Software Foundation (ASF) under one or more
      contributor license agreements.  See the NOTICE file distributed with
      this work for additional information regarding copyright ownership.
   ```
   
   It will prevent committing until you delete all offending licenses and 
re-insert licenses.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to