dstandish commented on code in PR #37101:
URL: https://github.com/apache/airflow/pull/37101#discussion_r1507904437
##########
airflow/datasets/__init__.py:
##########
@@ -106,8 +112,22 @@ class DatasetAny(_DatasetBooleanCondition):
agg_func = any
+ def __or__(self, other: BaseDatasetEventInput) -> DatasetAny:
+ # Optimization: X | (Y | Z) is equivalent to X | Y | Z.
Review Comment:
@sunank200 i think you meant to mark this as a todo?
i.e.
```
# todo: Optimization: X | (Y | Z) is equivalent to X | Y | Z.
```
i.e. should just tweak the language to make clear this is a _potential_
optimization, not one that is already committed that you are simply telling us
about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]