Taragolis commented on code in PR #37861:
URL: https://github.com/apache/airflow/pull/37861#discussion_r1510249300
##########
airflow/providers/amazon/aws/transfers/redshift_to_s3.py:
##########
@@ -109,27 +109,32 @@ def __init__(
) -> None:
super().__init__(**kwargs)
self.s3_bucket = s3_bucket
- self.s3_key = f"{s3_key}/{table}_" if (table and table_as_file_name)
else s3_key
+ if table and table_as_file_name:
+ s3_key = f"{s3_key}/{table}_"
Review Comment:
There is a good question what we attempt to fix there? Make pre-commit check
happy or fix the problem #29069
In this case this case we fix pre-commit check, however do not fix the
problem that every python object could be casted to string as result it might
the case that operator pass the init stage, however failed with random error on
execute/rendered templates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
