brokenjacobs opened a new issue, #37919: URL: https://github.com/apache/airflow/issues/37919
### Description There have been several releases in a row that have broken helm chart deployments of airflow using tools like fluxcd. If you do a helm install of the chart on the command line it works, but there are errors in the yaml output causing strict validation to fail. I suggest adding a check to PR's that update the helm chart to do the equivalent of: ``` helm template -f values.yaml ./ | kubeconform -strict ``` I'm not sure if I can just go add random github actions to this project, but I would suggest an approach like this: https://github.com/marketplace/actions/github-action-for-helm-templates-validation And we would need to pull the keda crds into the repo for use with kubeconform for these checks. A quick sanity check of this approach with the 1.13.0 release: ``` ❯ helm template -f values.yaml ./ | kubeconform -strict stdin - Deployment release-name-scheduler failed validation: error unmarshalling resource: error converting YAML to JSON: yaml: unmarshal errors: line 43: key "cluster-autoscaler.kubernetes.io/safe-to-evict" already set in map stdin - StatefulSet release-name-triggerer failed validation: error unmarshalling resource: error converting YAML to JSON: yaml: unmarshal errors: line 36: key "cluster-autoscaler.kubernetes.io/safe-to-evict" already set in map ``` I'm willing to submit a PR if someone can give me guidance as to if using an action for this is acceptable. ### Use case/motivation Preventing future errors in the helm chart through automated testing. ### Related issues https://github.com/apache/airflow/issues/37872 https://github.com/apache/airflow/issues/37794 ### Are you willing to submit a PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
