dabla commented on PR #37821: URL: https://github.com/apache/airflow/pull/37821#issuecomment-1983320874
> > Ok @eladkal it's because the branch was based on the other PR with proxy fix where I had to the new operator, so it will be hard to remove that file. What do you want me to do, create a new PR for this one based on main? > > It's just 3 lines. It would be simpler to just re-add these lines to the file (they exist in main but not in your branch) then just commit it. Once you do that the diff will be no changes to the file. > > Feel free to send me message on Slack if you need help Hello Edal, first of all thank you for your patience now I fully understand what happend. This file is indeed not the same as the main branch (I forgot to sync main on my repo hence why I didn't see the latestes updates and diff). But it should be changed, because it contains remains of the test of that new operator I had to remove back then if you remember, but on that PR I apparently forgot to remove those unused constants. Those constants are not used in that test anymore, so I would keep the changes as they clean up the test, but if you prefer to keep it then I will re-add those 3 lines if you want. Let me know what you I have to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
